nvme: enable cli for windows build#3544
Merged
igaw merged 1 commit intoJul 3, 2026
Merged
Conversation
bcapener
force-pushed
the
bcapener/enable-cli-on-windows
branch
from
8a38328 to
bf6a9db
Compare
bcapener
commented
Jul 2, 2026
| @@ -131,6 +133,10 @@ unsigned char *create_hash(const char *algo, | |||
| close(infd); | |||
|
|
|||
| return hash; | |||
| #else | |||
| /*Windows support will be added later*/ | |||
Collaborator
There was a problem hiding this comment.
I've merged #3545. Could you rebase it? Thanks!
igaw
reviewed
Jul 3, 2026
| 'nvme.c', | ||
| 'plugin.c', | ||
| ] | ||
| if host_system != 'windows' | ||
| sources += [ | ||
| 'libnvme-wrap.c', |
Collaborator
There was a problem hiding this comment.
I've removed libnvme-wrap.c as it is dead code anyway: #3547
This should result in only on feature adding for source files. Yay!
Collaborator
|
Very nice to see this landing soon! Fantastic job! |
Remove windows dummy cli target and add all relevant source files to the windows cli build. Signed-off-by: Brandon Capener <bcapener@micron.com>
bcapener
force-pushed
the
bcapener/enable-cli-on-windows
branch
from
bf6a9db to
df3c83c
Compare
Collaborator
|
Thanks a lot! I’m glad we got it working. After the heavy refactoring, the platform-specific code is now well compartmentalized, so I’d call this a win. 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove windows dummy cli target and add all relevant source files to the windows cli build.